Update dependencies #1532

szg251 · 2023-09-19T08:51:00Z

Updated some of the dependencies:

easy-ps
plutip (transitively haskell-nix, hackage-nix, iohk-nix and CHaP)
blockfrost
ogmios 5.6 -> 6; response format changed

Blocked by

mlabs-haskell/plutip#183

Pre-review checklist

All code has been formatted using our config (make format)
Any new API features or modification of existing behavior is covered as defined in our test plan
The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

…asy-ps, iohk.nix, CHaP)

szg251 · 2023-09-19T15:30:54Z

Plutip's local-cluster seems to be working correctly, spinning up the cluster with tada distributed, and keys generated.
I could also verify that plutip-server is working, and the cluster can be started with the /start endpoint.
I still have a problem with CTL: it can start the cluster, prepare the wallets, and query them, but it fails with a timeout when it's balancing a tx (before submitting a tx)

szg251 · 2023-09-21T18:24:22Z

Unfortunately I didn't have enough time to finish this, so I pushed my last results to 0fd1270

As discussed in a thread here, the latest versions of cardano-node (8.0.0 and above) require a new version of Ogmios (6.0). This version introduces a lot of breaking changes: most notably, they're using a standard JSON-RPC 2.0 scheme for the websocket messages. There's a beautiful migration guide here:
https://github.com/CardanoSolutions/ogmios/blob/master/architectural-decisions/accepted/017-api-version-6-major-rewrite.md#migration-guide

Last status:

renamed JsonWsp modules, data types etc to JsonRpc2
modified types and codecs in JsonRpc2 module to comply with the standard
updated ogmios most calls (see list below) in /src/Internal/QueryM/Ogmios.purs
updated most ogmios request and response types in the same module
updated protocol parameters data type
updated test schema in /fixtures/schemata/JsonRpc2/UtxoQueryResponse.medea
updated generate fixtures file

What's left:

finishing call type updates (method names are updated where I could find an equivalent in the new version)
verifying/updating error responses
finding out the story with stakePool queries: it looks like there's no poolIds query anymore, so a few things might have to change here

call	status
querySystemStartCall	request, success response
queryCurrentEpochCall	request, success response
queryEraSummariesCall	request, success response
queryProtocolParameters	request, success response
queryChainTipCall	request, success response
queryPoolIdsCall -> queryStakePoolsCall	method name only
queryPoolParametersCall	-
queryDelegationsAndRewards	method name only
submitTxCall	request, success response
evaluateTxCall	request, success response
acquireMempoolSnapshotCall	method name only
mempoolSnapshotHasTxCall	method name only
mempoolSnapshotNextTxCall	method name only
mempoolSnpashotSizeAndCapacityCall	method name only
releaseMempoolCall	method name only

Update posix times to match updated erasummary/startTime fixtures, encoding

klntsky · 2023-10-23T11:06:24Z

flake.nix

+    extra-substituters = [ "https://cache.iog.io" ];
+    extra-trusted-public-keys = [ "hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ=" ];


klntsky · 2023-10-23T11:07:05Z

fixtures/schemata/JsonRpc2/UtxoQueryResponse.medea

+        $property-name "jsonrpc"
+        $property-schema jsonRpcType
+        $property-name "method"


Where did you get this new schema from? Did you adapt it by hand?

klntsky · 2023-10-23T11:08:01Z

flake.nix

+    hackage-nix = {
+      url = "github:input-output-hk/hackage.nix";
+      flake = false;
+    };
+    haskell-nix = {
+      url = "github:input-output-hk/haskell.nix";
+      inputs.nixpkgs.follows = "nixpkgs";
+      inputs.hackage.follows = "hackage-nix";
+    };


Are these guaranteed to be compatible?

klntsky · 2023-10-23T11:14:26Z

plutip-server/cabal.project

+package cardano-wallet
+  optimization: False
+package cardano-wallet-core
+  optimization: False
+package cardano-wallet-cli
+  optimization: False
+package cardano-wallet-launcher
+  optimization: False
+package cardano-wallet-core-integration
+  optimization: False


Why do we need these disabled?

…parameter in ListenerSet

Also update blockfrost ProtocolParameters fixture to match Ogmios.

Was needed to decode ogmios response for `nextTx` with mempool tx, which is now encoded as Base16.

zmrocze · 2023-11-11T17:38:26Z

Thanks @szg251 for the status comment. Definitely helped to finish the pr.

zmrocze · 2023-11-11T17:45:15Z

@klntsky some easily missable details:

I removed tests concerning Ogmios Utxo query. It was obsolete already before, but went unnoticed. If you could double check these are unneeded.
removed Ogmios Utxo query fixtures and json schema
removed Base64 module - not needed as mempool tx is hex encoded now
minor changes to how decoding errors are handled - here im pretty sure behaviour is unchanged

aciceri · 2023-11-20T11:53:00Z

flake.nix

-    # ogmios nixos module (remove and replace with the above after merging and updating)
-    ogmios-nixos.url = "github:mlabs-haskell/ogmios";
+    kupo-nixos = {
+      url = "github:mlabs-haskell/kupo-nixos/6f89cbcc359893a2aea14dd380f9a45e04c6aa67";


We can remove the revision I believe.

@szg251 right?

aciceri · 2023-11-20T11:53:31Z

flake.nix

-      url = "github:input-output-hk/cardano-haskell-packages?ref=repo";
-      flake = false;
+    plutip = {
+      url = "github:mlabs-haskell/plutip/1bf0b547cd3689c727586abb8385c008fb2a3d1c";


Is there any reason why we fix the revision? @szg251

szg251 added 4 commits September 15, 2023 17:44

Update several packages (plutip, nixpkgs, haskell.nix, hackage.nix, e…

b0a3cb2

…asy-ps, iohk.nix, CHaP)

Reformat JS files with new version of prettier

daad2ae

Remove trailing commas in JS files (prettier configuration)

275b138

Update to fixed plutip (missing max tx size config)

6323d9d

szg251 added the help wanted Extra attention is needed label Sep 19, 2023

szg251 added 2 commits September 21, 2023 12:18

Upgrade to ogmios 6

bb80b24

Partially updating ogmios client after breaking changes on v6

0fd1270

klntsky assigned zmrocze Oct 2, 2023

klntsky added this to the F10M1 Updates, tidying the codebase milestone Oct 2, 2023

zmrocze mentioned this pull request Oct 18, 2023

Bump plutus version mlabs-haskell/plutip#183

Merged

zmrocze added 9 commits October 20, 2023 13:40

Easy ogmios updates

e9ac268

Update ogmios stake pools query

20b7388

Update query encoding/decoding to ogmios 6

076c9e2

Remove unused ogmios UTXO query types

7ae9a11

Remove obsolete ogmios UTXO query tests

f2da9f6

Update ogmios fixtures

6117dd2

Fix timeslot conversion test

f9675b4

Update posix times to match updated erasummary/startTime fixtures, encoding

Misc

4d011bd

Parse ogmios error responses on evaluateTx

ba111de

klntsky reviewed Oct 31, 2023

View reviewed changes

zmrocze added 8 commits November 3, 2023 14:21

Ogmios decoding with a class instead of datatype to restore response …

60a0dbd

…parameter in ListenerSet

Save full Ogmios response in fixtures

e2ea619

Also update blockfrost ProtocolParameters fixture to match Ogmios.

Add evaluateTx fixtures

f992478

Restore parsing of blockfrost evaluateTx responses (Ogmios v5.6)

a6e5f32

Fix test - ogmios decoding

559d8fa

Better blockfrost and ogmios evaluateTx return type

eccd587

Set ogmios include-transaction-cbor

c3ac43c

Fix decoding error messages

a0b5069

zmrocze added 5 commits November 10, 2023 20:49

Fix next mempool tx response decoding

b58f256

Remove unneeded Base64 module

c2ddcc8

Was needed to decode ogmios response for `nextTx` with mempool tx, which is now encoded as Base16.

Update nix ogmios fixtures

d692410

New submitTxE

ad0341b

Update CHANGELOG - ogmios update

cfd2eba

zmrocze requested a review from klntsky November 11, 2023 17:33

zmrocze added 2 commits November 11, 2023 18:56

Fix typo

81658db

Merge branch 'develop' into update-deps-1532

0840e95

zmrocze marked this pull request as ready for review November 11, 2023 18:20

Fix import

29181ab

klntsky mentioned this pull request Nov 13, 2023

Migrate to PureScript 0.15 #1521

Merged

3 tasks

klntsky added 2 commits November 13, 2023 23:51

Dropped medea-ps dependency

9e1fec3

Update CHANGELOG

018406c

klntsky approved these changes Nov 19, 2023

View reviewed changes

klntsky merged commit b212a58 into develop Nov 19, 2023
3 checks passed

klntsky deleted the gergely/update branch November 19, 2023 04:48

aciceri reviewed Nov 20, 2023

View reviewed changes

sadMaxim mentioned this pull request Nov 22, 2023

eraSummaries decoding error #1564

Closed

klntsky mentioned this pull request Dec 19, 2023

cardano-configurations new format is not compatible with what cardano-node expects #1482

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies #1532

Update dependencies #1532

szg251 commented Sep 19, 2023 •

edited by zmrocze

Loading

szg251 commented Sep 19, 2023

szg251 commented Sep 21, 2023

klntsky Oct 23, 2023

klntsky Oct 23, 2023

klntsky Oct 23, 2023

klntsky Oct 23, 2023

zmrocze commented Nov 11, 2023

zmrocze commented Nov 11, 2023

aciceri Nov 20, 2023

aciceri Nov 20, 2023

aciceri Nov 20, 2023

		extra-substituters = [ "https://cache.iog.io" ];
		extra-trusted-public-keys = [ "hydra.iohk.io:f/Ea+s+dFdN+3Y/G+FDgSq+a5NEWhJGzdjvKNGv0/EQ=" ];

Update dependencies #1532

Update dependencies #1532

Conversation

szg251 commented Sep 19, 2023 • edited by zmrocze Loading

Blocked by

Pre-review checklist

szg251 commented Sep 19, 2023

szg251 commented Sep 21, 2023

klntsky Oct 23, 2023

Choose a reason for hiding this comment

klntsky Oct 23, 2023

Choose a reason for hiding this comment

klntsky Oct 23, 2023

Choose a reason for hiding this comment

klntsky Oct 23, 2023

Choose a reason for hiding this comment

zmrocze commented Nov 11, 2023

zmrocze commented Nov 11, 2023

aciceri Nov 20, 2023

Choose a reason for hiding this comment

aciceri Nov 20, 2023

Choose a reason for hiding this comment

aciceri Nov 20, 2023

Choose a reason for hiding this comment

szg251 commented Sep 19, 2023 •

edited by zmrocze

Loading